Re: Memory leak with XLogFileCopy since de768844 (WAL file with .partial)

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Memory leak with XLogFileCopy since de768844 (WAL file with .partial)
Дата
Msg-id CAB7nPqQ9E3nbaYz8QuWezuOiOs03yOyqLUcQd6uuF3DgiQakOA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Memory leak with XLogFileCopy since de768844 (WAL file with .partial)  (Fujii Masao <masao.fujii@gmail.com>)
Ответы Re: Memory leak with XLogFileCopy since de768844 (WAL file with .partial)
Список pgsql-hackers
Дерево обсуждения 
On Fri, Jun 5, 2015 at 10:45 PM, Fujii Masao wrote:
> Why don't we call InstallXLogFileSegment() at the end of XLogFileCopy()?
> If we do that, the risk of memory leak you're worried will disappear at all.

Yes, that looks fine, XLogFileCopy() would copy to a temporary file,
then install it definitely. Updated patch attached.
--
Michael
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: [CORE] Restore-reliability mode
Следующее
От: Abhijit Menon-Sen
Дата:
Сообщение: skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory)