Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended
Дата
Msg-id CAB7nPqQ5XZd4AdbisXUyGGhsaOBM8Mk8BHK0uSB3XiPw5w-wiQ@mail.gmail.com
обсуждение исходный текст
Ответ на WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended  (Mark Dilger <mark@port25.com>)
Ответы Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Список pgsql-hackers
Дерево обсуждения


On Thu, Dec 11, 2014 at 7:44 AM, Mark Dilger <mark@port25.com> wrote:
At line 1787 of outfuncs.c, the line:

        WRITE_UINT_FIELD(reltablespace)

should probably say

        WRITE_OID_FIELD(reltablespace)

since that variable is of type Oid, not uint32.
Granted, these two macros are interchangeable,
but they won't be if we ever move to 64-bit Oids.
For correctness you are right. Looks like you spent quite some time looking at that..
--
Michael

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Too strict check when starting from a basebackup taken off a standby
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: On partitioning