Re: Patch: add psql tab completion for event triggers

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Patch: add psql tab completion for event triggers
Дата
Msg-id CAB7nPqQ4V4_iP_bM_nNZw8K+AEkFi+w=sMNMO3E=VwHeXEoY+g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Patch: add psql tab completion for event triggers  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
On Mon, Apr 14, 2014 at 9:46 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Wed, Apr 9, 2014 at 8:58 PM, Ian Barwick <ian@2ndquadrant.com> wrote:
>> Apologies again, that was ill-thought out. Revised patch attached with only
>> the additions related to event triggers, and the small fix for ALTER TRIGGER
>> mentioned above which ensures "RENAME TO" is applied only when "ALTER
>> TRIGGER <name> ON <sth>" was input; currently there is no check for a
>> preceding "ALTER", resulting in the spurious "RENAME TO" when completing
>> "CREATE EVENT TRIGGER".
>
> OK, committed.
>
> (I know this was submitted rather late, but I think we've often
> allowed tab-completion fixups at similar times in past releases, since
> they are quite mechanical.  If anyone feels that I shouldn't have
> committed this, please advise.)
+1 for this change even if it came late in-game. Patch is
straight-forward, and this is always useful to have.
-- 
Michael



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: four minor proposals for 9.5
Следующее
От: Fujii Masao
Дата:
Сообщение: Re: HEAD seems to generate larger WAL regarding GIN index