Re: Code inconsistency in convert.c for guid -> string conversion

On Tue, Mar 4, 2014 at 4:44 AM, Heikki Linnakangas
<hlinnakangas@vmware.com> wrote:
> On 03/03/2014 04:38 AM, Michael Paquier wrote:
>>
>> On another note, I found as well the following warning:
>> dlg_specific.c:1491: error: the address of 'conn_settings' will always
>> evaluate as 'true'
>
>
> Yeah, that has bothered me for a long time, but at a quick glance I haven't
> seen a very good way to fix it. Clearly the "conn_settings == NULL" test is
> unnecessary here, but the free() call that STR_TO_NAME also does is not, so
> we can't just replace the macro with an strcpy.
>
> Hmm, now that I look at it, we have a macro STRX_TO_NAME which is the same
> but without the NULL check. So we can just use that; that appears to be how
> it's used elsewhere too.
Thanks, I was not sure how to fix this one as well.
--
Michael