On Tue, Apr 4, 2017 at 7:03 PM, David Rowley
<david.rowley@2ndquadrant.com> wrote:
> On 4 April 2017 at 16:22, Michael Paquier <michael.paquier@gmail.com> wrote:
>> Hi all,
>>
>> In builds where USE_ASSERT_CHECKING is not enabled, costsize.c can
>> generate warnings. Here is for example with MSVC:
>> src/backend/optimizer/path/costsize.c(4520): warning C4101: 'rte' : unreferen
>> ced local variable [C:\Users\ioltas\git\postgres\postgres.vcxproj]
>> src/backend/optimizer/path/costsize.c(4640): warning C4101: 'rte' : unreferen
>> ced local variable [C:\Users\ioltas\git\postgres\postgres.vcxproj]
>>
>> a9c074ba7 has done an effort, but a bit more is needed as the attached.
>
> Thanks for writing the patch.
>
> I wondering if it would be worth simplifying it a little to get rid of
> the double #ifdefs, as per attached.
Yes, that would be fine as well.
--
Michael