Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

Hi Hackers,

@Murtuza: The patch codewise looks good. Nice to see that we are using axios instead of jquery ajax calls and that there is some coverage for the change.

Nevertheless the Javascript testing looks a bit slim and could be improved. Also the DataSorting class could have some other member functions like the model validation could be extracted out so that it is easily tested. 

@Hackers: This was how we tried to test this feature:

1 - Started pgAdmin

2 - Opened the query tool for a specific server

3 - Executed a SQL statment

4 - Pressed the column header to try to order, nothing happened

5 - Right clicked the column header to see if it was there the option, nothing

This is the behavior that we were expecting, not to have to open Data View and then press the icon that is not even near the grid in order to sort the column. Is this really the way we want people to use the grid in pgAdmin? Should it be more intuitive?

PS: Also that Orange after the selection is like a push in the eyes and not in a good way. Maybe we should think about changing the color of the icon to blue to match the rest of the website or something.

Thanks

Victoria & Joao

On Mon, Mar 26, 2018 at 12:13 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

On Mon, Mar 26, 2018 at 5:52 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

PFA patch which allow user to sort the data in View data mode.

The patch looks good in general, however I'm not sure about the UI, in particular that the closely-linked dialogue for filtering is a completely different design. I think it would be better to combine the Sort/Filter options and use a single dialogue for both, as pgAdmin 3 did (though, maybe not using separate tabs for each part, but the top and bottom of the same dialogue.

That would certainly fix the consistency of the dialogues (obviously, as there would only be one!), and I think would perhaps be a more simple overall UI, particularly for those that want to sort and filter.

​Sure, I'll send updated it accordingly.​

 

Thoughts?

Thanks. 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company