Re: ExecRTCheckPerms() and many prunable partitions

Поиск
Список
Период
Сортировка
От David Rowley
Тема Re: ExecRTCheckPerms() and many prunable partitions
Дата
Msg-id CAApHDvrU9Hp2AbVM0vKgOcaNgpDQQgKyYu8DPvFD3hBQGC5g+A@mail.gmail.com
обсуждение исходный текст
Ответ на ExecRTCheckPerms() and many prunable partitions  (Amit Langote <amitlangote09@gmail.com>)
Ответы Re: ExecRTCheckPerms() and many prunable partitions  (Amit Langote <amitlangote09@gmail.com>)
Список pgsql-hackers
Дерево обсуждения 
On Thu, 1 Jul 2021 at 01:34, Amit Langote <amitlangote09@gmail.com> wrote:
> For now, I have implemented the idea 2 as the attached patch.

I only just had a fleeting glance at the patch. Aren't you
accidentally missing the 0th RTE here?

+ while ((rti = bms_next_member(checkPermRels, rti)) > 0)
  {
- RangeTblEntry *rte = (RangeTblEntry *) lfirst(l);
+ RangeTblEntry *rte = (RangeTblEntry *) list_nth(rangeTable, rti - 1);

I'd have expected >= 0 rather than > 0.

David

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Bharath Rupireddy
Дата:
Сообщение: Re: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values?
Следующее
От: Alexander Pyhalov
Дата:
Сообщение: Re: Partitioned index can be not dumped