On Fri, 29 Nov 2024 at 18:50, songjinzhou <tsinghualucky912@foxmail.com> wrote:
> Hello, thank you and David Rowley for your comments.
>
> I have used pgindent to adjust the code format and added comments and missing regression test cases. Here is the
patchof version v3.
It looks fine to me. The only things I'd adjust are stylistic,
namely; 1) remove two tabs before the goto label, 2) remove redundant
braces around the goto cleanup, 3) rename the variable "q" to
something slightly more meaningful, maybe "res" or "rows".
I'll defer to Dean.
David