> I've just had a look at both of these patches. All tests that > have been added seem to cover new areas that are not previously > tested, they also seem to cleanup properly after themselves, so I > think these should be a worthwhile addition to the regression > tests.
Thanks for reviewing! Did you happen to note the impact on `make check` runtime? There are many people who run that many times per day while working on development, so we try to keep new tests that significantly extend that separate. We haven't quite worked out the best way to exercise such longer-running tests, but I suspect we soon will. At any rate, this is a piece of information the committer will want, so you will be helping whoever that is if you can supply it.
I've done a quick benchmark on this this morning.
Note that I'm using windows here and I used powershell to time the regression run with the following command: