Re: short circuit suggestion in find_hash_columns()

Поиск
Список
Период
Сортировка
От David Rowley
Тема Re: short circuit suggestion in find_hash_columns()
Дата
Msg-id CAApHDvqSCvJrc0XQcuqkBFkTue=oKVeDCqBib3DOwd6FguyCcA@mail.gmail.com
обсуждение исходный текст
Ответ на short circuit suggestion in find_hash_columns()  (Zhihong Yu <zyu@yugabyte.com>)
Ответы Re: short circuit suggestion in find_hash_columns()
Список pgsql-hackers
On Sat, 10 Jul 2021 at 03:15, Zhihong Yu <zyu@yugabyte.com> wrote:
> I was looking at find_hash_columns() in nodeAgg.c
>
> It seems the first loop tries to determine the max column number needed, along with whether all columns are needed.
>
> The loop can be re-written as shown in the patch.

This runs during ExecInitAgg().  Do you have a test case where you're
seeing any performance gains from this change?

David



В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: Record a Bitmapset of non-pruned partitions
Следующее
От: David Rowley
Дата:
Сообщение: Re: enable_resultcache confusion