I'm just looking into an issue I've found in the find_inner_rels() function, where it does not properly find the rel in the from list in certain cases, for example:
explain select * from a where id not in (select b.id from b left outer join c on b.id=c.id);
fails to use an ANTI JOIN, but if you remove the left join to c, it works perfectly.
Currently I'm just getting my head around how the jointree is structured and reading over deconstruct_jointree to see how it handles this. I may change the function to find_outer_rels and just look for outer joins in the function.
However, assigning it to author to think on above cosmetic issues.
Thanks for the review. I'll fix the issues you listed soon, but I'll likely delay posting the updated patch until I have the other fix in place.
Regards
David Rowley
Thanks
--
Jeevan B Chalke Principal Software Engineer, Product Development EnterpriseDB Corporation The Enterprise PostgreSQL Company