On Wed, 28 Jul 2021 at 02:33, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > 0001: Removes an include directory for dblink. This appears like it's
> > not needed. It was added in ee3b4188a (Jan 2010), but an earlier
> > commit, 320c7eb8c (June 2008) seems to have made it pointless. It's
> > still a mystery to me why ee3b4188a would have been required in the
> > first place.
>
> FWIW, I poked around in the mailing list archives around that date
> and couldn't find any supporting discussion. It does seem like it
> shouldn't be needed, given that dblink's Makefile does no such thing.
I think the reason is that src/backend/utils/Makefile symlinks
fmgroids.h into src/include/utils. The copy you added in 320c7eb8c
seems to be the MSVC build's equivalent of that.
David