Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values

Поиск
Список
Период
Сортировка
От David Rowley
Тема Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values
Дата
Msg-id CAApHDvp=OhwDG+wgF=hxCXN=Pa=Xi4foiVea4Kz7gpH34PVArQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values  (Greg Nancarrow <gregn4422@gmail.com>)
Ответы Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values
Список pgsql-hackers
Дерево обсуждения 
On Wed, 7 Jul 2021 at 00:06, Greg Nancarrow <gregn4422@gmail.com> wrote:
> I think if you're going to reject this patch, a brief comment should
> be added to that code to justify why that existing superfluous check
> is worthwhile.

It seems strange to add a comment to explain why it's there. If we're
going to the trouble of doing that, then we should just remove it and
add a very small comment to mention why INT8 sequences don't need to
be checked.

Patch attached

David
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: "debug_invalidate_system_caches_always" is too long
Следующее
От: Andy Fan
Дата:
Сообщение: Re: Keep notnullattrs in RelOptInfo (Was part of UniqueKey patch series)