Re: Add explicit initialization for all PlannerGlobal fields

Поиск
Список
Период
Сортировка
От David Rowley
Тема Re: Add explicit initialization for all PlannerGlobal fields
Дата
Msg-id CAApHDvp3R1CcmZ2WxsvVANZu05104gTPV=biKm+ix-H+-2YmNQ@mail.gmail.com
обсуждение исходный текст
Ответ на Add explicit initialization for all PlannerGlobal fields  (Richard Guo <guofenglinux@gmail.com>)
Ответы Re: Add explicit initialization for all PlannerGlobal fields
Список pgsql-hackers
On Tue, 13 May 2025 at 04:03, Richard Guo <guofenglinux@gmail.com> wrote:
> While adding a new field to PlannerGlobal in another patch, I noticed
> that although most fields are explicitly initialized, a few are not.
> This doesn't cause any functional issues, since makeNode() zeroes all
> fields by default.  However, the inconsistency stood out to me, so I
> wrote the attached patch to explicitly initialize the remaining fields
> for clarity and consistency.
>
> Does this seem worthwhile?  Or should we simply rely on makeNode() for
> zero-initialization and consider this unnecessary?

These should be zeroed explicitly.

David



В списке pgsql-hackers по дате отправления: