Re: logical changeset generation v6.8
| От | David Rowley |
|---|---|
| Тема | Re: logical changeset generation v6.8 |
| Дата | |
| Msg-id | CAApHDvp0UZAaVEe6nGbDkCC3cTUA8Ca_YAtp3xaiaMbZD-DM6g@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: logical changeset generation v6.8 (Robert Haas <robertmhaas@gmail.com>) |
| Ответы |
Re: logical changeset generation v6.8
|
| Список | pgsql-hackers |
On Wed, Dec 11, 2013 at 1:11 PM, Robert Haas <robertmhaas@gmail.com> wrote:
Committed #1 (again). Regarding this:
This introduced a new compiler warning on the visual studios build:
d:\postgres\b\src\backend\utils\cache\relcache.c(3958): warning C4715: 'RelationGetIndexAttrBitmap' : not all control paths return a value [D:\Postgres\b\postgres.vcxproj]
The attached patch fixes it.
Regards
David Rowley
+ /* XXX: we could also do this unconditionally, the space is used anyway
+ if (copy_oid)
+ HeapTupleSetOid(key_tuple, HeapTupleGetOid(tp));
I would like to put in a big +1 for doing that unconditionally. I
didn't make that change before committing, but I think it'd be a very
good idea.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Вложения
В списке pgsql-hackers по дате отправления: