Re: small erreport bug over partitioned table pgrowlocks module

Поиск
Список
Период
Сортировка
От David Rowley
Тема Re: small erreport bug over partitioned table pgrowlocks module
Дата
Msg-id CAApHDvovZ--CaRs6zHqaKsuoGyXTwg-wVswGxFdBTQb_O=Xj8A@mail.gmail.com
обсуждение исходный текст
Ответ на small erreport bug over partitioned table pgrowlocks module  (jian he <jian.universality@gmail.com>)
Ответы Re: small erreport bug over partitioned table pgrowlocks module  (David Rowley <dgrowleyml@gmail.com>)
Список pgsql-hackers
On Tue, 31 Oct 2023 at 13:00, jian he <jian.universality@gmail.com> wrote:
> BEGIN;
> CREATE TABLE fk_parted_pk (a int PRIMARY KEY) PARTITION BY LIST (a);
> SELECT * FROM pgrowlocks('fk_parted_pk');
> ERROR:  only heap AM is supported
>
> error should be the following part:
> if (rel->rd_rel->relkind == RELKIND_PARTITIONED_TABLE)
> ereport(ERROR,
> (errcode(ERRCODE_WRONG_OBJECT_TYPE),
> errmsg("\"%s\" is a partitioned table",
> RelationGetRelationName(rel)),
> errdetail("Partitioned tables do not contain rows.")));

Yeah.  Seems that 4b8266415 didn't look closely enough at the other
error messages and mistakenly put the relam check first instead of
last.

Here's a patch that puts the relam check last.

David

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: jian he
Дата:
Сообщение: small erreport bug over partitioned table pgrowlocks module
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Requiring recovery.signal or standby.signal when recovering with a backup_label