Re: Fix segfault while accessing half-initialized hash table in pgstat_shmem.c

Поиск
Список
Период
Сортировка
От Mikhail Kot
Тема Re: Fix segfault while accessing half-initialized hash table in pgstat_shmem.c
Дата
Msg-id CAAi9E7ge4APjZ_atDce+qjYODnxuRwmNej-9RhL3Ydi3zRs8bw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Fix segfault while accessing half-initialized hash table in pgstat_shmem.c  (Ranier Vilela <ranier.vf@gmail.com>)
Ответы 回复: Fix segfault while accessing half-initialized hash table in pgstat_shmem.c
Re: Fix segfault while accessing half-initialized hash table in pgstat_shmem.c
Список pgsql-hackers
Hi Michael, Steven, and Ranier,

> Anyway, couldn't we flip the order of the operations in
pgstat_init_entry() so as we do first an allocation and avoid any inconsistency
in the shared state?

The issue is not only in pgstat_init_entry(). Currently it errors on OOM but
this doesn't prevent us from calling pgstat_lock_entry() through
pgstat_get_entry_ref() which accesses a non-initialized lock.

Here's the second version of the patch. Now we remove inserted hash entry
on OOM which would prevent accessing the entry

Вложения

В списке pgsql-hackers по дате отправления: