Re: [PATCH] pg_dump: Sort overloaded functions in deterministic order

Поиск
Список
Период
Сортировка
От Joel Jacobson
Тема Re: [PATCH] pg_dump: Sort overloaded functions in deterministic order
Дата
Msg-id CAASwCXdtEWWGzX=Egw--prWcWaoj_EYMBiwMC161XBxHsicT_g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] pg_dump: Sort overloaded functions in deterministic order  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [PATCH] pg_dump: Sort overloaded functions in deterministic order  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
I agree, good suggestion, I just didn't know how to implement it without a new field. I'll make a new attempt to get it right.

On Thursday, July 5, 2012, Tom Lane wrote:
Joel Jacobson <joel@trustly.com> writes:
> New version, made a typo in last one.

I'm not particularly happy with the idea of adding a sortkey field to
DumpableObject as such, when most object types don't need it.  That just
bloats the code and pg_dump's memory consumption.  It would be better to
modify the already-existing object-type-specific special cases in
DOTypeNameCompare to take additional information into account as needed.

BTW, I see no reason to be adding extra calls of
pg_get_function_identity_arguments.  What is wrong with the funcsig or
aggsig strings that the code already computes?

                        regards, tom lane

В списке pgsql-hackers по дате отправления:

Предыдущее
От: John Lumby
Дата:
Сообщение: Re: proposal and patch : support INSERT INTO...RETURNING with partitioned table using rule
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: plpython issue with Win64 (PG 9.2)