Re: Fix overflow of nbatch

Поиск
Список
Период
Сортировка
От Melanie Plageman
Тема Re: Fix overflow of nbatch
Дата
Msg-id CAAKRu_auu0ex7p=2sZKz8XW6XWS5x4_+M289F=Qt1GhnMpV5yw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Fix overflow of nbatch  (Melanie Plageman <melanieplageman@gmail.com>)
Список pgsql-hackers
On Mon, Oct 13, 2025 at 12:05 PM Melanie Plageman
<melanieplageman@gmail.com> wrote:
>
> On Thu, Oct 9, 2025 at 7:36 PM Tomas Vondra <tomas@vondra.me> wrote:
> >
> > 1) A couple comments adjusted. It feels a bit too audacious to correct
> > comments written by native speaker, but it seems cleaner to me like this.
>
> I attached a patch with a few more suggested adjustments (0003)

Oh and I didn't add this but, all of the other pointer dereferences
have unnecessary (in terms of operator precedence) parentheses around
them, so, for consistency, I would put them around this (or remove
them everywhere since they are not needed)

if (nbatch < *space_allowed / BLCKSZ)
        break;

- Melanie



В списке pgsql-hackers по дате отправления: