Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro

Поиск
Список
Период
Сортировка
От Amul Sul
Тема Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro
Дата
Msg-id CAAJ_b97s2W7UdXCAhECGt3wonqzvOBGWmpaSWg_+_m90U0vyeg@mail.gmail.com
обсуждение исходный текст
Ответ на retire MemoryContextResetAndDeleteChildren backwards compatibility macro  (Nathan Bossart <nathandbossart@gmail.com>)
Ответы Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro  (Nathan Bossart <nathandbossart@gmail.com>)
Список pgsql-hackers
On Tue, Nov 14, 2023 at 12:30 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
I just found myself researching the difference between MemoryContextReset()
and MemoryContextResetAndDeleteChildren(), and it turns out that as of
commit eaa5808 (2015), there is none.
MemoryContextResetAndDeleteChildren() is just a backwards compatibility
macro for MemoryContextReset().  I found this surprising because it sounds
like they do very different things.

Shall we retire this backwards compatibility macro at this point?  A search
of https://codesearch.debian.net/ does reveal a few external uses, so we
could alternatively leave it around and just update Postgres to stop using
it, but I don't think it would be too burdensome for extension authors to
fix if we removed it completely.
 
+1

Patch attached.

Changes looks pretty much straight forward, but patch failed to apply on the
latest master head(b41b1a7f490) at me.

Regards,
Amul

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: Allow tests to pass in OpenSSL FIPS mode
Следующее
От: Peter Eisentraut
Дата:
Сообщение: Re: meson documentation build open issues