On Wed, Jun 20, 2018 at 2:06 PM, Daniel Gustafsson <daniel@yesql.se> wrote:
>> On 27 Apr 2018, at 04:24, Andres Freund <andres@anarazel.de> wrote:
>>
>> On 2018-04-27 11:52:18 +0930, Tom Dunstan wrote:
>>>> I'd argue this should contain the non-error cases. It's just as
>>>> reasonable to want to add this as a debug level or such.
>>>
>>> So all of warning, info, debug and debug1-5?
>>
>> Yea. Likely nobody will ever use debug5, but I don't see a point making
>> that judgement call here.
>
> Did you have a chance to hack up a new version of the patch with Andres’ review
> comments? I’m marking this patch as Waiting on Author for now based on the
> feedback so far in this thread.
>
Here is an updated version of the patch. Setting this to "needs review".
I haven't added tests for auto_explain - I think that would be useful
but it's a separate project.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services