Re: [Proposal] Adding callback support for custom statistics kinds

Поиск
Список
Период
Сортировка
От Sami Imseih
Тема Re: [Proposal] Adding callback support for custom statistics kinds
Дата
Msg-id CAA5RZ0vQvmatp8VAk6zroyeKDCw+QVq4XmoRNAFogQo6bJEbNQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [Proposal] Adding callback support for custom statistics kinds  (Chao Li <li.evan.chao@gmail.com>)
Ответы Re: [Proposal] Adding callback support for custom statistics kinds
Список pgsql-hackers
> My point is that, there are many places jumping to “error”, then from “error” goto “done”,
> if an error didn’t happen from the deserialize callback, how end_extra_stats()
> can know if failure happened and takes action accordingly?

IIUC, if *any* error occurs outside of a deserialize callback, first the "error"
code will be called, followed by "done" which will then trigger the
end_extra_stats
callback that will perform the cleanup.

Attached is v6 with a few minor indentation fixes and a correction to
freeing the file in the cleanup callback.

--
Sami Imseih
Amazon Web Services (AWS)

Вложения

В списке pgsql-hackers по дате отправления: