Re: Question about StartLogicalReplication() error path

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: Question about StartLogicalReplication() error path
Дата
Msg-id CAA4eK1LyM9JbTNH_HQ0Sh7Gim0tGi1HbM5SqH7sHkp4mqi8adQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Question about StartLogicalReplication() error path  (Jeff Davis <pgsql@j-davis.com>)
Список pgsql-hackers
On Thu, Jun 17, 2021 at 4:25 AM Jeff Davis <pgsql@j-davis.com> wrote:
>
> On Tue, 2021-06-15 at 15:19 +0900, Kyotaro Horiguchi wrote:
> > I don't think the message is neded, but I don't oppose it as far as
> > the level is LOG and the messages were changed as something like
> > this:
> >
> >
> > -               elog(DEBUG1, "cannot stream from %X/%X, minimum is
> > %X/%X, forwarding",
> > +               elog(LOG, "%X/%X has been already streamed,
> > forwarding to %X/%X",
> >
> > FWIW, I most prefer #1. I see #2 as optional. and see #3 as the
> > above.
>
> Attached.
>

LGTM.

-- 
With Regards,
Amit Kapila.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: locking [user] catalog tables vs 2pc vs logical rep
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Unresolved repliaction hang and stop problem.