Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

On Tue, Mar 25, 2025 at 5:30 PM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> On Thu, Mar 20, 2025 at 5:54 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > *  <refsynopsisdiv>
> > +  <cmdsynopsis>
> > +   <command>pg_createsubscriber</command>
> > +   <arg rep="repeat"><replaceable>option</replaceable></arg>
> > +   <group choice="plain">
> > +    <group choice="req">
> > +     <arg choice="plain"><option>-a</option></arg>
> > +     <arg choice="plain"><option>--all</option></arg>
> > +    </group>
> > +    <group choice="req">
> > +     <arg choice="plain"><option>-D</option> </arg>
> > +     <arg choice="plain"><option>--pgdata</option></arg>
> > +    </group>
> > +    <replaceable>datadir</replaceable>
> > +    <group choice="req">
> > +     <arg choice="plain"><option>-P</option></arg>
> > +     <arg choice="plain"><option>--publisher-server</option></arg>
> > +    </group>
> > +    <replaceable>connstr</replaceable>
> >
> > Most of this is unrelated to this patch. I suggest making a top-up
> > patch, we can commit it separately.
>
> Isn't this documenting -a/--all option in synopsis. Why do you think
> it's unrelated?
>

I was not clear at that stage whether to include it along with the
core patch, but today, I looked at it while responding to Euler and
found that it is not required. We can still discuss whether to include
it, but the main patch can be committed even without this.

--
With Regards,
Amit Kapila.