On Tue, Sep 17, 2013 at 3:29 PM, Rushabh Lathia
<rushabh.lathia@gmail.com> wrote:
> Hi Amit.
>
> I gone through the mail thread discussion regarding this issue and reviewed
> you patch.
>
> -- Patch get applied cleanly on Master branch
> -- Make and Make Install fine
> -- make check also running cleanly
>
> In the patch code changes looks good to me.
>
> This patch having two part:
>
> 1) Allowed TableOid system column in the CHECK constraint
> 2) Throw an error if other then TableOid system column in CHECK constraint.
>
> I noticed that you added test coverage for 1) but the test coverage for 2)
> is missing.. Initially I thought of keeping the test for point-2 as well, but
later left it thinking it might not add much value for adding negative
test for this scenario.
> I added the test coverage for 2) in the attached patch. Thanks for adding new test.
> Marking this as Ready for committer.
Thanks a ton for reviewing the patch.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
>
>
> On Sun, Sep 15, 2013 at 2:31 PM, Amit Kapila <amit.kapila16@gmail.com>
> wrote:
>>
>> Bruce Momjian wrote:
>> On Sun, Jun 30, 2013 at 06:57:10AM +0000, Amit kapila wrote:
>> >> >> I have done the initial analysis and prepared a patch, don't know if
>> >> >> anything more I can do until
>> >> >> someone can give any suggestions to further proceed on this bug.
>> >
>> > > >So, I guess we never figured this out.
>> >
>> >> I can submit this bug-fix for next commitfest if there is no objection
>> >> for doing so.
>> >> What is your opinion?
>>
>> > Yes, good idea.
>>
>> I had rebased the patch against head and added the test case to validate
>> it.
>> I will upload this patch to commit fest.