On Fri, Mar 7, 2014 at 7:59 PM, Bruce Momjian <bruce@momjian.us> wrote:
> On Fri, Mar 7, 2014 at 07:18:04PM +0530, Amit Kapila wrote:
>> > OK, done with the attached patch Three is returned for status, but one
>> > for other cases.
>>
>> I think it would have been better if it return status as 4 for cases where
>> directory/file is not accessible (current new cases added by this patch).
>>
>> I think status 3 should be only return only when the data directory is valid
>> and pid file is missing, because in script after getting this code, the next
>> thing they will probably do is to start the server which doesn't seem a
>> good fit for newly added cases.
>
> OK, I have updated the attached patch to reflect this, and added a C
> comment.
This is fine, do you think we should mention about this in docs?
I have added one line in docs (updated patch attached), if you think
it makes sense then add it otherwise ignore it.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com