On Sat, Mar 20, 2021 at 10:09 AM Ajin Cherian <itsajin@gmail.com> wrote:
>
> On Sat, Mar 20, 2021 at 1:35 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>> On Fri, Mar 19, 2021 at 5:03 AM Ajin Cherian <itsajin@gmail.com> wrote:
>> >
>> > Missed the patch - 0001, resending.
>> >
>>
>> I have made miscellaneous changes in the patch which includes
>> improving comments, error messages, and miscellaneous coding
>> improvements. The most notable one is that we don't need an additional
>> parameter in walrcv_startstreaming, if the two_phase option is set
>> properly. My changes are in v63-0002-Misc-changes-by-Amit, if you are
>> fine with those, then please merge them in the next version. I have
>> omitted the dev-logs patch but feel free to submit it. I have one
>> question:
>>
>
> I am fine with these changes. I see that Peter has already merged in these changes.
>
I have further updated the patch to implement unique GID on the
subscriber-side as discussed in the nearby thread [1]. That requires
some changes in the test. Additionally, I have updated some comments
and docs. Let me know what do you think about the changes?
[1] - https://www.postgresql.org/message-id/CAA4eK1+opiV4aFTmWWUF9h_32=HfPOW9vZASHarT0UA5oBrtGw@mail.gmail.com
--
With Regards,
Amit Kapila.