Re: Forget close an open relation in ReorderBufferProcessTXN()

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: Forget close an open relation in ReorderBufferProcessTXN()
Дата
Msg-id CAA4eK1KkBEmbzPifY3Wq6kapNaERVMMwA2oXW52ZHAuT0HKbxA@mail.gmail.com
обсуждение исходный текст
Ответ на Forget close an open relation in ReorderBufferProcessTXN()  (Japin Li <japinli@hotmail.com>)
Ответы Re: Forget close an open relation in ReorderBufferProcessTXN()
Re: Forget close an open relation in ReorderBufferProcessTXN()
Список pgsql-hackers
Дерево обсуждения 
On Thu, Apr 15, 2021 at 4:00 PM Japin Li <japinli@hotmail.com> wrote:
>
> The RelationIdGetRelation() comment says:
>
> > Caller should eventually decrement count. (Usually,
> > that happens by calling RelationClose().)
>
> However, it doesn't do it in ReorderBufferProcessTXN().
> I think we should close it, here is a patch that fixes it. Thoughts?
>

+1. Your fix looks correct to me but can we test it in some way?

-- 
With Regards,
Amit Kapila.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Truncate in synchronous logical replication failed