Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby
Дата
Msg-id CAA4eK1KZ72BLdx8ByzGAv9zSmJ1R7EG1_b+z+38781AuBsP6-A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby  (Michael Paquier <michael.paquier@gmail.com>)
Ответы Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
On Mon, Feb 8, 2016 at 12:28 PM, Michael Paquier <michael.paquier@gmail.com> wrote:
>
>
> >>       /*
> >> +      * Fetch the progress position before taking any WAL insert lock. This
> >> +      * is normally an operation that does not take long, but leaving this
> >> +      * lookup out of the section taken an exclusive lock saves a couple
> >> +      * of instructions.
> >> +      */
> >> +     progress_lsn = GetProgressRecPtr();
> >
> > too long for my taste. How about:
> > /* get progress, before acuiring insert locks to shorten locked section */
>
> Check.
>

What is the need of holding locks one-by-one during checkpoint when
we anyway are going to take lock on all the insertion slots.

+ * to not rely on taking an exclusive lock an all the WAL insertion locks,

/an all/on all

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: [ADMIN] 9.5 new setting "cluster name" and logging
Следующее
От: Andres Freund
Дата:
Сообщение: process type escape for log_line_prefix