Re: Hard to maintain duplication in contain_volatile_functions_not_nextval_walker

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: Hard to maintain duplication in contain_volatile_functions_not_nextval_walker
Дата
Msg-id CAA4eK1KNEyv55WgrktshUQOzU4JwT_aupCkTaQuP_=zYJsLoNA@mail.gmail.com
обсуждение исходный текст
Ответ на Hard to maintain duplication in contain_volatile_functions_not_nextval_walker  (Andres Freund <andres@anarazel.de>)
Ответы Re: Hard to maintain duplication in contain_volatile_functions_not_nextval_walker  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
On Sat, May 28, 2016 at 12:28 AM, Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> contain_volatile_functions_walker is duplicated, near entirely, in
> contain_volatile_functions_not_nextval_walker.
>

Previously, I also had same observation.

> Wouldn't it have been better not to duplicate, and keep a flag about
> ignoring nextval in the context variable?
>

makes sense.  +1 for doing it in the way as you are suggesting.


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: [GENERAL] Permission Denied Error on pg_xlog/RECOVERYXLOG file
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Parallel pg_dump's error reporting doesn't work worth squat