Re: Skipping logical replication transactions on subscriber side

On Fri, Jan 14, 2022 at 5:35 PM vignesh C <vignesh21@gmail.com> wrote:
>
> Thanks for the updated patch, few minor comments:
> 1) Should "SKIP" be "SKIP (" here:
> @@ -1675,7 +1675,7 @@ psql_completion(const char *text, int start, int end)
>         /* ALTER SUBSCRIPTION <name> */
>         else if (Matches("ALTER", "SUBSCRIPTION", MatchAny))
>                 COMPLETE_WITH("CONNECTION", "ENABLE", "DISABLE", "OWNER TO",
> -                                         "RENAME TO", "REFRESH
> PUBLICATION", "SET",
> +                                         "RENAME TO", "REFRESH
> PUBLICATION", "SET", "SKIP",
>

Won't the another rule as follows added by patch sufficient for what
you are asking?
+ /* ALTER SUBSCRIPTION <name> SKIP */
+ else if (Matches("ALTER", "SUBSCRIPTION", MatchAny, "SKIP"))
+ COMPLETE_WITH("(");

I might be missing something but why do you think the handling of SKIP
be any different than what we are doing for SET?

-- 
With Regards,
Amit Kapila.