Re: Wrong return code in vacuumdb when multiple jobs are used

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: Wrong return code in vacuumdb when multiple jobs are used
Дата
Msg-id CAA4eK1K+MtdYvvQO5QgEEh0iDiSdavnr3z3TBYWw3SEf1i_c2Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Wrong return code in vacuumdb when multiple jobs are used  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Wrong return code in vacuumdb when multiple jobs are used  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Sat, May 4, 2019 at 2:45 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Sat, May 04, 2019 at 10:35:23AM +0200, Julien Rouhaud wrote:
> > While reading vacuumdb code, I just noticed that it can return 0 if an
> > error happen when -j is used, if errors happen on the last batch of
> > commands.
>
> Yes, I agree that this is wrong.  GetIdleSlot() is much more careful
> about that than vacuum_one_database(), so your patch looks good at
> quick glance.
>

The fix looks good to me as well.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: Unhappy about API changes in the no-fsm-for-small-rels patch
Следующее
От: Federico Razzoli
Дата:
Сообщение: season of docs proposal