On Sun, Nov 24, 2013 at 10:22 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Amit Kapila <amit.kapila16@gmail.com> writes:
>> I think that still this kind of problems can be there at other
>> places in code. I checked few places and suspecting secure_read() can
>> also have similar problem:
>
>> case SSL_ERROR_SSL:
>> ereport(COMMERROR,
>> (errcode(ERRCODE_PROTOCOL_VIOLATION),
>> errmsg("SSL error: %s", SSLerrmessage())));
>> /* fall through */
>
> Note that what it "falls through" to is "errno = ECONNRESET", so the
> caller will see a well-defined value of errno after this. Even without
> the ereport call, I'd think that was necessary because SSL_get_error
> isn't documented to return a meaningful value of errno except in the
> SSL_ERROR_SYSCALL case.
Yes, that is right. Idea is that there can be more occurrences which
we might need to handle and the same seems to be taken care in your
latest commit.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com