On Tue, Nov 30, 2021 at 11:03 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> On Mon, Nov 29, 2021 11:38 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
>
> 2)
> + /* Reinitialize the parallel context to relaunch parallel workers */
> + if (!pvs->first_time)
>
> It seems the ParallelVacuumState::first_time was not initialized before ?
>
Yeah, I also notice this while looking at the patch.
One more thing it seems the patch has removed even the existing error
callback from parallel_vacuum_main. I suggested that we can enhance or
add a new one if required in a separate patch but let's keep the
current one as it is.
Can we think of splitting the patch in the following manner: (a) the
patch to get rid of bitmap to represent whether particular index
supports parallel vacuum and rename of functions (b) any other stuff
to improve the current implementation, (c) move the parallel vacuum
related code to a separate file?
I think if we can split the patch, it will be easier to review and
reduce the chances of introducing any bugs in this area.
--
With Regards,
Amit Kapila.