Re: Logical Replication of sequences

On Fri, Oct 24, 2025 at 8:52 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Thu, 23 Oct 2025 at 16:47, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Thu, Oct 23, 2025 at 11:45 AM vignesh C <vignesh21@gmail.com> wrote:
> > >
> > > The attached patch has the changes for the same.
> > >
> >
> > I have pushed 0001 and the following are comments on 0002.
> >
> > 1.
> > @@ -1414,6 +1414,7 @@ CREATE VIEW pg_stat_subscription_stats AS
> >          ss.subid,
> >          s.subname,
> >          ss.apply_error_count,
> > +        ss.sequence_sync_error_count,
> >          ss.sync_error_count,
> >
> > The new parameter name is noticeably longer than other columns. Can we
> > name it as ss.seq_sync_error_count. We may also want to reconsider
> > changing existing column sync_error_count to tbl_sync_error_count. Can
> > we extract this in a separate stats patch?
>
> Modified and extracted a separate patch for tbl_sync_error_count
>

Hmm, I didn't want to make the stats related changes before the main
patch. I suggested to extract seq_sync_error_count from the main patch
and keep it after the main patch. Along with the seq_sync_error_count
stats, we can discuss whether to change existing parameter to
tbl_sync_error_count.

--
With Regards,
Amit Kapila.