On Tue, Aug 16, 2022 at 8:30 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> ii)
> Line:452(publication.sql)
> -- column list for partitioned tables has to cover replica identities for
> -- all child relations
>
> OK - That does seem to have leaf partitions with PK and a partitioned
> table without PK, but OTOH this is in the scope of column list testing
>
> So, I agree with you - it does seem all the cases are covered. But,
> IMO this is quite a large file which is too hard to digest all at
> once, and because of that I still felt that keeping all related test
> cases grouped together (even if that causes some doubling-up of a few
> scenarios) would be better for future readability/maintenance than
> relying on some distantly scattered tests to cover everything. Anyway,
> I leave it for you to decide whether to add more tests or not.
>
I am not sure if repeating tests is a good idea. However, if you find
a better way to group the tests, feel free to propose them separately.
--
With Regards,
Amit Kapila.