Re: Parallel INSERT (INTO ... SELECT ...)

On Wed, Nov 4, 2020 at 6:11 AM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Tue, Nov 3, 2020 at 5:25 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > -> commandType is not used, we can remove it.
> > + * Prepare for entering parallel mode by assigning a FullTransactionId, to be
> > + * included in the transaction state that is serialized in the parallel DSM.
> > + */
> > +void PrepareParallelModeForModify(CmdType commandType)
> > +{
> > +       Assert(!IsInParallelMode());
> > +
> > +       (void)GetCurrentTransactionId();
> > +}
>
> Thanks, at least for INSERT, it's not needed, so I'll remove it.
>

Or you might want to consider moving the check related to
IsModifySupportedInParallelMode() inside
PrepareParallelModeForModify(). That way the code might look a bit
cleaner.


-- 
With Regards,
Amit Kapila.