Re: logicalrep_message_type throws an error

On Fri, Jul 21, 2023 at 6:28 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Fri, Jul 21, 2023 at 1:39 AM Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> >
> > On Thu, Jul 20, 2023 at 9:11 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > >
> > > > Okay, changed it accordingly.
> > > >
> > >
> > > oops, forgot to attach the patch.
> > >
> >
> > WFM
> >
> > @@ -3367,7 +3367,7 @@ apply_dispatch(StringInfo s)
> >          default:
> >              ereport(ERROR,
> >                      (errcode(ERRCODE_PROTOCOL_VIOLATION),
> > -                     errmsg("invalid logical replication message type
> > \"%c\"", action)));
> > +                     errmsg("invalid logical replication message type
> > \"??? (%d)\"", action)));
> >
> > I think we should report character here since that's what is visible
> > in the code and also the message types are communicated as characters
> > not integers. Makes debugging easier. Context may report integer as an
> > additional data point.
>
> I think it could confuse us if an invalid message is not a printable character.
>

Right. I'll push and backpatch this till 15 by Tuesday unless you guys
think otherwise.


--
With Regards,
Amit Kapila.