Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size
Дата
Msg-id CAA4eK1+h4WumWRrKNBk+vbEsLpPJXvGzkJXwdDeym4TC87OZjw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size  (vignesh C <vignesh21@gmail.com>)
Список pgsql-hackers
On Thu, Jan 23, 2025 at 6:42 PM Shubham Khanna
<khannashubham1197@gmail.com> wrote:
>
> Fixed the given comments. The attached patch contains the suggested changes.
>

I am fine with giving a WARNING for max_slot_wal_keep_size but I don't
think we need a test for each and every setting required for
pg_createsubscriber. This will add time to the tests without adding
much value. So, I don't think this patch deserves an additional test.

--
With Regards,
Amit Kapila.



В списке pgsql-hackers по дате отправления: