Re: "Some tests to cover hash_index"

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: "Some tests to cover hash_index"
Дата
Msg-id CAA4eK1+eDHSm1SQ4EJsh-q2ycFnjecbG7oVNzo1HakfGhFa7Zg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: "Some tests to cover hash_index"  (Ashutosh Sharma <ashu.coek88@gmail.com>)
Ответы Re: "Some tests to cover hash_index"  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
On Wed, Aug 24, 2016 at 11:38 AM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
> Hi,
>
>> Well, that change should be part of Amit's patch to add WAL logging,
>> not this patch, whose mission is just to improve test coverage.
>
> I have just removed the warning message from expected output file as i
> have performed the testing on Amit's latest patch that removes this
> warning message from the  hash index code.
>

I think you are missing what Robert wants to point out.  You don't
need to remove the warning message when you are adding new test cases
on top of Mithun's patch even if those new tests helps to cover the
code path which is required for wal-hash-index patch.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Fabien COELHO
Дата:
Сообщение: Re: pgbench - minor doc improvements
Следующее
От: Etsuro Fujita
Дата:
Сообщение: Collective typos in contrib/postgres_fdw (Was: Re: Incorrect comment in contrib/postgres_fdw/deparse.c)