Re: [PATCH v1] eliminate duplicate code in table.c

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: [PATCH v1] eliminate duplicate code in table.c
Дата
Msg-id CAA4eK1+N-bZivTO=2LZH93jxQAwSi+0xvW-Gg1yN_WS2PujwMQ@mail.gmail.com
обсуждение исходный текст
Ответ на [PATCH v1] eliminate duplicate code in table.c  (Junwang Zhao <zhjwpku@gmail.com>)
Ответы Re: [PATCH v1] eliminate duplicate code in table.c  (Aleksander Alekseev <aleksander@timescale.com>)
Список pgsql-hackers
On Thu, Jul 21, 2022 at 1:56 PM Junwang Zhao <zhjwpku@gmail.com> wrote:
>
> There are some duplicate code in table.c, add a static inline function
> to eliminate the duplicates.
>

Can we name function as validate_object_type, or check_object_type?

Otherwise, the patch looks fine to me. Let's see if others have
something to say.

-- 
With Regards,
Amit Kapila.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Следующее
От: Thomas Munro
Дата:
Сообщение: Re: standby recovery fails (tablespace related) (tentative patch and discussion)