Re: POC: Cleaning up orphaned files using undo logs

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: POC: Cleaning up orphaned files using undo logs
Дата
Msg-id CAA4eK1+3_BPYaqxcs83wVMtzr39k+ypy3QKZjK2AeTAACzWMag@mail.gmail.com
обсуждение исходный текст
Ответ на Re: POC: Cleaning up orphaned files using undo logs  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: POC: Cleaning up orphaned files using undo logs  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
On Sat, Jul 6, 2019 at 1:47 AM Robert Haas <robertmhaas@gmail.com> wrote:
>
> In fact, it seems to me that we shouldn't have any such thing as
> "queue entries" at all.  The queues should just be pointing to
> RollbackHashEntry *, and we should add all the fields there that are
> present in any of the "queue entry" structures.  This would use less
> memory still.
>

As of now, after we finish executing the rollback actions, the entry
from the hash table is removed.  Now, at a later time (when queues are
full and we want to insert a new entry) when we access the queue entry
(to check whether we can remove it)  corresponding to the removed hash
table entry, will it be safe to access it?  The hash table entry might
have been freed or would have been reused as some other entry by the
time we try to access it.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Fetter
Дата:
Сообщение: Re: range_agg
Следующее
От: Fabien COELHO
Дата:
Сообщение: Re: pgbench - add \aset to store results of a combined query