On Wed, Jun 30, 2021 at 7:38 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> PFA v9 patch set for further review.
>
The first patch looks mostly good to me. I have made some minor
modifications to the 0001 patch: (a) added/edited few comments, (b)
there is no need to initialize supported_opts variable in
CreateSubscription, (c) used extra bracket in macro, (d) ran pgindent.
Kindly check and let me know what you think of the attached? I am not
sure whether second patch is an improvement over what we have
currently but if you and others feel that is a good idea then you can
submit the same after the main patch gets committed.
--
With Regards,
Amit Kapila.