Re: Materialized View Patch File

Поиск
Список
Период
Сортировка
От Thom Brown
Тема Re: Materialized View Patch File
Дата
Msg-id CAA-aLv4N9fnU9cv9kr8Z=bnuW7PHTwii6u+GiBj2Lk3ghqqA2g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Materialized View Patch File  (Neel Patel <neel.patel@enterprisedb.com>)
Ответы Re: Materialized View Patch File  (Dave Page <dave.page@enterprisedb.com>)
Список pgadmin-hackers
On 29 May 2013 10:40, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find the updated patch after fixing some of the issues and comments
> given by Ashesh.

Just realised this reply has been in my draft folder for over a month...


This comment appears to be incomplete:

//While editing the view, if it is materialized view then only change


The section of if... else if... else if... that begins with:

if (name == wxT("autovacuum_vacuum_cost_delay"))

should probably use:

switch(name)
{
    case wxT("autovacuum_vacuum_cost_delay")

    case ...
}


Given the amount of duplicate functionality this shares with tables,
is there not a way there could be a common class they could both
inherit from to reduce maintenance overhead?

--
Thom


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: Materialized View Patch File
Следующее
От: Dave Page
Дата:
Сообщение: Re: Materialized View Patch File