Re: PATCH: PGADMIN 4 - FTS templates node

Поиск
Список
Период
Сортировка
От Sanket Mehta
Тема Re: PATCH: PGADMIN 4 - FTS templates node
Дата
Msg-id CA+yw=mNuzL-ZOPhN2HeM=4X5TZKjyLi+r4SXqvtfNdGo32SyhA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: PATCH: PGADMIN 4 - FTS templates node  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Hi Dave,

All comments are resolved.
PFA the revised patch.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Thu, Feb 25, 2016 at 7:37 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Feb 23, 2016 at 1:44 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

PFA the revised patch for fts template node which includes dependency and dependent route handling code.
Please do review it and if found proper please do commit it.

- When creating a new template, errors in the dialogue are not cleared - e.g. the "Name must not be empty" doesn't clear, and save is not enabled, even when a name is entered.

- "Fts Templates" should be "FTS Templates" on the treeview.

- The "Init" field should be labelled "Init Function"

- The "Lexize" field should be labelled "Lexize Function"

- Selecting a schema should be optional, with the default being the current schema.

- 4 character indents are not consistently used in SQL templates 

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Ashesh Vashi
Дата:
Сообщение: pgAdmin 4 commit: [Reversed Engineered SQL] Security Labels is not avai
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin4][Patch]: Support for asynchronous connection in psycopg2