Re: [PATCH] Add pg_get_subscription_ddl() function
| От | Vaibhav Dalvi |
|---|---|
| Тема | Re: [PATCH] Add pg_get_subscription_ddl() function |
| Дата | |
| Msg-id | CA+vB=AFsqT4DkdJzDUfNSx6xLMiijWbbOrb=7uJoynHfAURnjw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [PATCH] Add pg_get_subscription_ddl() function (Álvaro Herrera <alvherre@kurilemu.de>) |
| Ответы |
Re: [PATCH] Add pg_get_subscription_ddl() function
Re: [PATCH] Add pg_get_subscription_ddl() function Re: [PATCH] Add pg_get_subscription_ddl() function |
| Список | pgsql-hackers |
Hi Alvaro,
I've realized this, I think stripping those values out of the String wrapping
is the wrong direction to go in, because it leads to more contortions
rather than less.
I also agree with you. I couldn't explain it well so I thought of doing the changes.
Please find the attached patch which introduces a new static function to convert
text array to string list instead of making textarray_to_stringlist() non-static.
Request to please review the attached v5 patch.
Regards,
Vaibhav
On Tue, Nov 11, 2025 at 5:04 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
On 2025-Nov-11, Vaibhav Dalvi wrote:
> Hi Alvaro,
>
> Thanks for the explanation.
>
> I tried to get rid of String usage in 0001 patch.
> Prepared 0002 patch for actual implementation of the
> function p_get_subscription_ddl().
OK, now I understand what you meant when you mentioned
CreateSubscriptionStmt: the problem is that the same code is being used
for the purposes of processing the subscription lists of both
Subscription and SubscriptionStmt. I think this whole code is a bit
ugly TBH -- not yours, but what was there before -- but now that I've
realized this, I think stripping those values out of the String wrapping
is the wrong direction to go in, because it leads to more contortions
rather than less.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"They proved that being American is not just for some people"
(George Takei)
Вложения
В списке pgsql-hackers по дате отправления: