Re: Fix GetOperatorFromCompareType

Поиск
Список
Период
Сортировка
От Paul A Jungwirth
Тема Re: Fix GetOperatorFromCompareType
Дата
Msg-id CA+renyW0NUF47D7k1Z0VVuASwNTAZpvW89fEoLVOFkZOFTiNnQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Fix GetOperatorFromCompareType  (Neil Chen <carpenter.nail.cz@gmail.com>)
Список pgsql-hackers
On Sun, Nov 16, 2025 at 11:18 PM Neil Chen <carpenter.nail.cz@gmail.com> wrote:
> After your patch changes, the line '*opid = InvalidOid;' seems removable.
>
> Also, if the second validation check of opclass after 'get_opclass_method' feels a bit odd, moving
'get_opclass_opfamily_and_input_type'to the very top would work -- purely for visual clarity. :) 

Thanks for the review! Here is a patch with your suggestions incorporated.

Yours,

--
Paul              ~{:-)
pj@illuminatedcomputing.com

Вложения

В списке pgsql-hackers по дате отправления: