Re: [HACKERS] Create subscription with `create_slot=false` andincorrect slot name

Поиск
Список
Период
Сортировка
От Dmitry Dolgov
Тема Re: [HACKERS] Create subscription with `create_slot=false` andincorrect slot name
Дата
Msg-id CA+q6zcXH1rHF=y23obvZSsBdM4FtE8feBKFkiLLQ484A5K0Zfw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] Create subscription with `create_slot=false` andincorrect slot name  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Список pgsql-hackers
Дерево обсуждения
> On 26 May 2017 at 23:05, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>
> > On 5/25/17 19:16, Petr Jelinek wrote:
> >> The reported error is just one of many errors that can happen when DROP
> >> SUBSCRIPTION tries to drop the slot (doens't exist, still active, no
> >> permission, etc.).  We don't want to give the hint that is effectively
> >> "just forget about the slot then" for all of them.  So we would need
> >> some way to distinguish "you can't do this right now" from "this would
> >> never work" (400 vs 500 errors).
> >>
> > This specific error returns ERRCODE_UNDEFINED_OBJECT error code so we
> > could check for it and offer hint only for this case.
>
> We would have to extend the walreceiver interface a little to pass that
> through, but it seems doable.

Just to make it clear for me. If I understand correctly, it should be more or
less easy to extend it in that way, something like in the attached patch.
Or am I missing something?
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: [HACKERS] Get stuck when dropping a subscription duringsynchronizing table
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] Tweaking tab completion for some backslash commands