On Thu, Jul 7, 2016 at 11:08 AM, Devrim Gündüz <devrim@gunduz.org> wrote:
>
> Hi Daniele,
>
> On Thu, 2016-07-07 at 04:10 +0100, Daniele Varrazzo wrote:
>> Psycopg 2.6.2 has been released. You can get it from:
>>
>> http://initd.org/psycopg/tarballs/PSYCOPG-2-6/psycopg2-2.6.2.tar.gz
>
> So, I noticed a changes in minor release, which I think is not a good idea,
> which is in setup.cfg. Not to mention about the removal of the comments in the
> file, pg_config parameter has been removed from the default conf. Any reasons
> why?
>
> FWIW, adding it to setup.cfg still works.
>
> Any reason why? I will have to update my patch for this release :P
Aww! No, it wasn't supposed to be that :\ I haven't changed that file
in the source code
https://github.com/psycopg/psycopg2/blob/2_6_2/setup.cfg
it is setuptools messing up with that file: verified by using
distutils for a test. Googling for the problem (setuptools rewriting
setup.cfg) I couldn't find anything. Grrr... I hated including it in
this release but it was necessary for Python 3.5, windows, wheels...
I've opened this ticket for it: https://github.com/psycopg/psycopg2/issues/453
Suggestions? Can we survive this way for this release? I've changed
the content of setup.cfg using empty options instead of comments so at
least the options, if not the comments, appear in the munged setup.cfg
(see the ticket). I would like to see if other problems related to
setuptools appear with this release, in which case I'd roll back to
distutils, release a quick 2.6.3 and postpone using setuptools in 2.7.
-- Daniele