On Wed, May 1, 2019 at 12:57 PM Noah Misch <noah@leadboat.com> wrote:
> On Tue, Apr 30, 2019 at 10:47:37PM +1200, Thomas Munro wrote:
> > --- a/src/test/perl/PostgresNode.pm
> > +++ b/src/test/perl/PostgresNode.pm
> > @@ -1098,17 +1098,12 @@ sub get_new_node
> > # native Perl (https://stackoverflow.com/a/14388707),
> > so we also test
> > # individual addresses.
> > #
> > - # This seems like a good idea on Unixen as well, even
> > though we don't
> > - # ask the postmaster to open a TCP port on Unix. On Non-Linux,
> > - # non-Windows kernels, binding to 127.0.0.1/24
> > addresses other than
> > - # 127.0.0.1 fails with EADDRNOTAVAIL.
> > - #
>
> Deleting that comment paragraph isn't quite right, since we're still testing
> 127.0.0.1 everywhere. The paragraph does have cause to change.
Hi Noah,
I put the second sentence back and tweaked it thus: s/fails/might
fail/. Maybe I'm being too pedantic here, but binding to 127.0.0.2
works on other OSes too, as long as you've configured an interface or
alias for it (and it's not terribly uncommon to do so). Here's a
version with a commit message. Please let me know if you want to
tweak the comments further.
--
Thomas Munro
https://enterprisedb.com